Apply suggestions from code review

Co-authored-by: George Steel <[email protected]> Signed-off-by: Michał Iżewski <[email protected]>
mezzio · May 7, 2024 · e571fe6 · e571fe6
1 parent 9a76d8c
commit e571fe6
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/CacheSessionPersistence.php b/src/CacheSessionPersistence.php
@@ -145,7 +145,7 @@ public function persistSession(SessionInterface $session, ResponseInterface $res
         // Regenerate the session if:
         // - we have no session identifier
         // - the session is marked as regenerated
-        // - the session has changed (data is different) and autoRegenerate is turned off in the configuration
+        // - the session has changed (data is different) and autoRegenerate is turned on (default) in the configuration
         if ('' === $id || $session->isRegenerated() || ($this->autoRegenerate && $session->hasChanged())) {
             $id = $this->regenerateSession($id);
         }

diff --git a/test/CacheSessionPersistenceIntegrationTest.php b/test/CacheSessionPersistenceIntegrationTest.php
@@ -112,7 +112,7 @@ public function testThatAChangedSessionWillCauseRegenerationAndASetCookieHeader(
         self::assertNull($value, 'The previous session data should have been deleted');
     }
 
-    public function testThatAChangedSessionWillNotCauseRegenerationAndASetCookieHeader(): void
+    public function testThatAChangedSessionWillNotCauseRegenerationWhenAutoRegenerateIsFalse(): void
     {
         $this->storage = new CacheSessionPersistence(
             $this->cache,