Added the error free and tested functionality to move folders into another folder. Work for all types of folders (#933) #1379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… folder into another folder
…elected folders into new parent folder
…lows to select folders so they can be moved
…feature of moving folders into a new foder
…move folder location
…ove.ts] To move dataroom-folder into another dataroom-folder
…le to handle both dataroom folder and also ordinary folders to be moved freely and makes approriate API call to move folder location
…ionality of filtering folders data to made this component with new feature of moving dataroom folders into another dataroom folder
…components compatiable for the functionality to move datarrom folders into other folders
…ders] In this modification code is giving more meaningful toast errors to user to identify the cause of invalid folder selection.
|
@SubhPB is attempting to deploy a commit to the mftsio Team on Vercel. A member of the Team first needs to authorize it. |
|
@mfts Please let me know if there will be something to do in this code or if you want me to add more videos as proof or any more explanation about code. Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull request, i enabled the user to move folders into another folder. It also works for dataroom folders. It is complete error free and fully tested as it was said in #933 .
An overview of what changes i have made:
Created 2 new api endpoints one for simple folder and other for dataroom folder.
i has implemented all the security checks and also solved all the possible edge cases. There were multiple edge cases. i worked very hard in code readability you can easily read and check how i have solved all of those.
All update is handled very preciously and smoothly in a careful way.
Modified Existing Components such as SidebarSelectionTree for both (Folder and DataroomFolder)
In order to make those components compatible with this new feature i had to implement an optional filter function so that user can't select any invalid new parent folder. This change is 100% compatible with existing code
New Modal specific to move folders into another folder
I introduced a new modal capable to handle both types of folders. Upon form submission it do a good job to check the validity, also give the appropriate meaningful errors if user selects an invalid new parent folder. It internally calls
move-folders-into-foldera newly created function to make the API requestModified existing component named
FolderCardThis component did not have any option about
move folder. but now i have included a new option of move folder and it also works for both types of folders.Here is the video of my solution.
feat-933.mp4
@mfts All code has been done in a clean way with meaningful comments. This was a bit complex problem but i believe it would not be hard for anyone to understand the code and solution. I would be very happy to get feedback about my solution and how overall my code was. Please feel free to ask if you need any modification or anything in the code.