Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor UI warning fix in Add Document Modal #1424

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

avikalpg
Copy link

What was wrong?

When you open the add-document-modal, an error and a warning will come up on the browser console (see screenshot of papermark.io below).
Screenshot 2024-12-25 at 8 38 53 AM

How did I fix it?

I just followed the instructions in the error/warning messages (add invisible DialogTitle and DialogDescription elements). The error/warning messages no longer show up (see screenshot of localhost below).
Screenshot 2024-12-25 at 8 46 12 AM

@avikalpg avikalpg requested a review from mfts as a code owner December 25, 2024 03:25
Copy link

vercel bot commented Dec 25, 2024

@avikalpg is attempting to deploy a commit to the mftsio Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

github-actions bot commented Dec 25, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@avikalpg
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@avikalpg
Copy link
Author

recheck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant