added docker compose file. #533
Open
+85
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArpitBlagan
commented
Jul 23, 2024
•
ArpitBlagan
commented
|
Someone is attempting to deploy a commit to the mftsio Team on Vercel. A member of the Team first needs to authorize it. |
mfts
requested changes
Jul 23, 2024
There was a problem hiding this comment.
Overall good. There's another PR open for a pure dockerfile #532. But I definitely like the docker-compose approach with the database.
Would it be possible to specify the different env variables before running the docker compose? Like notification emails won't work without Resend currently. Planning to offer also smtp, for self-hosting. Currently we also rely on trigger, but might be able to escape that for self-hosting.
|
Yes before running docker compose up just simple create .env file and change or add all the variables that are needed. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.