Qt: Fix installer updates if a version number is in the filename (fixes

#3109)
mgba-emu · Nov 25, 2024 · 9a38ba4 · 9a38ba4
1 parent 2f880b1
commit 9a38ba4
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGES b/CHANGES
@@ -20,6 +20,7 @@ Other fixes:
  - Qt: Fix LCDC background priority/enable bit being mis-mapped in I/O view
  - Qt: Fix saving named states breaking when screenshot states disabled (fixes mgba.io/i/3320)
  - Qt: Fix potential crash on Wayland with OpenGL (fixes mgba.io/i/3276)
+ - Qt: Fix installer updates if a version number is in the filename (fixes mgba.io/i/3109)
  - Updater: Fix updating appimage across filesystems
 Misc:
  - Qt: Make window corners square on Windows 11 (fixes mgba.io/i/3285)

diff --git a/src/platform/qt/GBAApp.cpp b/src/platform/qt/GBAApp.cpp
@@ -316,7 +316,7 @@ void GBAApp::cleanupAfterUpdate() {
 void GBAApp::restartForUpdate() {
 	QFileInfo updaterPath(m_updater.updateInfo().url.path());
 	QDir configDir(ConfigController::configDir());
-	if (updaterPath.completeSuffix() == "exe") {
+	if (updaterPath.suffix() == "exe") {
 		m_invokeOnExit = configDir.filePath(QLatin1String("update.exe"));
 	} else {
 		QFile updater(":/updater");