Check in BizHawk build scripts #3272
Conversation
There was a problem hiding this comment.
You should remove the XCode project if no one is using it. Further, I can already confirm this won't build. I'd like to at least try to make sure the bizinterface DLL builds via CI so I know when I'm gonna be breaking things for you. It looks like the last time this was downstreamed was several months ago, as you reference some files I've removed, so I'd like it if you can get it building again before I merge this.
|
Removed files and dropped one source entry from the |
There was a problem hiding this comment.
Most of my concerns are about if this builds, if it continues to build (I might want to set up some sort of CI?) and that it doesn't diverge from downstream (at least, not for too long).
I'm A-OK with it being upstreamed if these things can be managed adequately.
| cd "$BASEDIR/src/platform/bizhawk/mingw" | ||
| fi | ||
| make clean | ||
| make -j4 |
There was a problem hiding this comment.
Recommendation:
| make -j4 | |
| make -j${JOBS:-4} |
This lets you override the job number from the environment if desired, but defaults to 4 if it's not present.
There was a problem hiding this comment.
Gentoo and Arch have established a precedent for something like make ${MAKEOPTS:-j4}
| -Wall -Wno-stringop-overflow -Wno-lto-type-mismatch \ | ||
| -Wno-ignored-optimization-argument -Wno-unknown-warning-option \ | ||
| -DMINIMAL_CORE=2 -DDISABLE_THREADING -DM_CORE_GBA \ | ||
| -DCOLOR_16_BIT -DMGBA_STANDALONE -DENABLE_DEBUGGERS \ |
There was a problem hiding this comment.
I'm going to need to test if this compiles. I changed a bunch of the build flags somewhat recently, so this may not work anymore.
| $(ROOT_DIR)/debugger/symbols.c \ | ||
| $(ROOT_DIR)/debugger/parser.c \ | ||
| $(ROOT_DIR)/third-party/inih/ini.c \ | ||
| $(ROOT_DIR)/util/circle-buffer.c \ |
There was a problem hiding this comment.
You'll need to add util/audio-buffer.c and possibly util/audio-resampler.c now that blip_buf is dead.
| #include "mgba/core/log.h" | ||
| #include "mgba/core/timing.h" | ||
| #include "mgba/core/serialize.h" | ||
| #include "mgba/core/blip_buf.h" |
There was a problem hiding this comment.
blip_buf will need to be replaced with mAudioBuffer and mAudioResampler to work anymore.
Yes that's all the changes as of
bizhawk-0.11. And I think some of that can be removed still,namely the Xcode project filesgone. The last upstream change to be merged in was cecb454, but I've rebased, so one of the changes since then may have broken the build.How much of this you keep, or drop, or keep with modifications is up to you. The C FFI can be changed slightly too.
re: TASEmulators/BizHawk#2312