Skip to content
This repository has been archived by the owner on Oct 7, 2021. It is now read-only.

Eye_rigger: Fix for tilted- or asian eyes #57

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ivogrig
Copy link

@ivogrig ivogrig commented Sep 4, 2020

Currently the middle vertices for the upper- and lower curves are
required to be the ones with the highest/lowest Y-value.

With a tilted eye this yields unexpected behavior (breaks).
This is an attempt to fix that issue.

lid_error

Currently the middle vertices for the upper- and lower curves are
required to be the ones with the highest/lowest Y-value.

With a tilted eye this yields unexpected behavior (breaks).
This is an attempt to fix that issue.
@ivogrig
Copy link
Author

ivogrig commented Sep 4, 2020

I just realised that this solution is kind of assuming a particular eye-shape again and the closest-point would not work with donald duck-eyes either.
So the best fix would actually be to let the user manually override the mid-points through the GUI
image

@miquelcampos
Copy link
Member

Hello @ivogrig ,

Thanks for the pull request. I will check this ASAP :)

one question: using the custom eye corners, did work with your model?
image

@miquelcampos miquelcampos self-assigned this Sep 5, 2020
@miquelcampos miquelcampos added the enhancement New feature or request label Sep 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants