Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEWS #44

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

NEWS #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
840d585
NEWS
mgirlich Mar 20, 2023
5805b8e
Update `cran-comments.md`
mgirlich Mar 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# jsontools (development version)
# jsontools 0.1.1

* Fixed the consistency with `vctrs::vec_ptype_full()` and
`vctrs::vec_ptype_abbr()`.
Expand Down
19 changes: 5 additions & 14 deletions cran-comments.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,11 @@
## Resubmission
This is a resubmission. In this version I have:
This is a minor release just to fix the CRAN check result errors:

* Documented return values in `json_merge.Rd`, `parse_json.Rd`, `read_json.Rd`,
and `vec_cast.json2.Rd`.
* In the following documenting the return type does not really make sense:
* `object.Rd`: This is not a documentation of a function or data but only a
separate topic to be shown in the help.
* `pipe.Rd`: Documentation of the magrittr pipe `%>%`.
* The methods for `vctrs::vec_ptype_full()` and `vctrs::vec_ptype_abbr()` are
now consistent to the generic.

## Test environments
* local OS X install, R 3.6.1
* ubuntu 14.04 (on travis-ci), R 3.6.1
* win-builder (devel and release)
* local OS X install, R 4.2.0

## R CMD check results

0 errors | 0 warnings | 1 note

* This is a new release.
0 errors | 0 warnings | 0 notes