Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified daemon with lockfile and added channels option #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

marc252
Copy link

@marc252 marc252 commented Mar 14, 2018

Since daemon.pidlockfile didn't work with my python version I changed it with lockfile.pidlockfile
Also I added the channel option since my device has 3 channels

@mhagdorn
Copy link
Owner

Hi @marc252,
glad you found this useful. I am sorry to have slightly neglected it as I did similar fixes to you quite a while back. I have updated my repo. Are you using linux to run this program? I keep thinking I should turn this into a deb package or at least use setup tools to make it installable.

@marc252
Copy link
Author

marc252 commented Mar 20, 2018

Hi Magnus, I'm using linux on a raspberry pi (raspbian). My goal is to create a datalogger for the currentcost envir and maybe a simple web to graph results.
I think we could improve this script much more, create init scripts, solve rotation issues, manage different channels, different locales etc.
About the debian package I think it's a good idea when all the additions are made, for a single script it doesn't make your life easier having it in a deb package, but if we had init scripts, cron files, config files etc then it would make more sense.
Still, the daemon pid lockfile is an issue depending on the python version you are using.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants