Fix some importlib usages #2123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
commented
Sep 21, 2023
| @@ -6,7 +6,7 @@ | |||
| # when things go wrong - eg, not enough permissions to hit the | |||
| # registry etc. | |||
|
|
|||
| import importlib | |||
| import importlib.machinery | |||
There was a problem hiding this comment.
See python/typeshed#10746 (comment) as to why importing directly from importlib shouldn't be relied on for importlib.machinery, importlib.util and importlib.abc. Mypy & Pyright (see #2102) will also catch this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See python/typeshed#10746 (comment) as to why importing directly from
importlibshouldn't be relied on forimportlib.machinery,importlib.utilandimportlib.abc.Mypy & Pyright (see #2102) will also catch the two issues fixed here.