Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant str() calls and prefer !r marker for repr in formatting #2272

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Avasam
Copy link
Collaborator

@Avasam Avasam commented May 29, 2024

As title says:

  • prefer more succint {!r} over repr
  • avoid unnecessary calls to str() and repr()

Will also reduce changes in #2223

Expecting a few slight behaviour changes: " vs ' in some strings where it should not matter, especially in traces, logs, debugging, tests, etc.

@Avasam Avasam force-pushed the repr-marker-and-redundant-str-coercion branch from 7534c57 to 5f60c7d Compare May 29, 2024 05:08
@Avasam Avasam changed the title Remove redundant str coercion and prefer !r marker for repr in formatting Remove redundant str() callsand prefer !r marker for repr in formatting May 29, 2024
@Avasam Avasam changed the title Remove redundant str() callsand prefer !r marker for repr in formatting Remove redundant str() calls and prefer !r marker for repr in formatting May 29, 2024
@Avasam Avasam force-pushed the repr-marker-and-redundant-str-coercion branch from 5f60c7d to 7604677 Compare May 29, 2024 05:31
@vernondcole
Copy link
Collaborator

Edits in adodbapi subsystem look great. Will this merge cleanly with the adodbapi branch? I suspect that it will.
I am still experimenting with a set of VMs that can do a proper test of adodbapi. My entire development system these days is on Linux, so testing Windows stuff is a challenge. I suspect that the final result will be something that we can eventually add as an option to the CI build system.

@Avasam
Copy link
Collaborator Author

Avasam commented Jun 1, 2024

Hi @vernondcole ! I meant to split adodbapi changes as I usually do to make it easier for you and Mark to review without depending on each other! I'll go and split this off right now.

Will this merge cleanly with the adodbapi branch?

Maybe, maybe not, but I'm usually pretty quick about fixing any conflict. You can merge any current adodbapi PR in any order you want.

Edit: There you go: #2276

@Avasam Avasam force-pushed the repr-marker-and-redundant-str-coercion branch from 111ce60 to a99a772 Compare October 4, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants