Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adodbapi: Simplify dict iterations from Python 2 to 3 migration #2332

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

adodbapi: Simplify dict iterations from Python 2 to 3 migration #2332

wants to merge 12 commits into from
+148 −141

Conversation

Avasam
Copy link
Collaborator

@Avasam Avasam commented Jul 26, 2024 •
edited
Loading

  • Python 2 to 3 automatic migration tooling added a bunch of unneeded list calls when the dict_keys/dict_values/dict_items object is immediately iterated upon.

Equivalent non-adodbapi PR: #2331

@Avasam Avasam requested a review from vernondcole July 26, 2024 23:57
@Avasam Avasam mentioned this pull request Jul 26, 2024
Merged
@Avasam Avasam mentioned this pull request Jul 27, 2024
Open
@Avasam Avasam mentioned this pull request Oct 18, 2024
Open
@Avasam Avasam requested a review from mhammond October 18, 2024 17:54
Avasam
Avasam commented Oct 18, 2024
View reviewed changes
CHANGES.txt Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vernondcole vernondcole Awaiting requested review from vernondcole

@mhammond mhammond Awaiting requested review from mhammond

Assignees
No one assigned
Labels
adodbapi
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Avasam