Fix bugs in TimeZoneInfo.tzname #2337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
approved these changes
Jul 27, 2024
Avasam
reviewed
Jul 28, 2024
| """ | ||
|
|
||
| winInfo = self.getWinInfo(dt.year) | ||
| if self.dst(dt) == -winInfo.daylight_bias: |
There was a problem hiding this comment.
I just noticed, but probably better not to repeat self.dst call up to 3 times.
There was a problem hiding this comment.
I'm a little reluctant to spend energy optimizing a function that's never been used. It's also unnecessary to address this bugfix. Let's leave it for another contrib (be my guest).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing #2334, we learned that .tzname didn't work at all. This patch adds a couple of tests and updates it to pass those tests.