Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify part of, type and cleanup py2d.py #2385

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Simplify part of, type and cleanup py2d.py #2385

wants to merge 2 commits into from
+78 −76

Conversation

Avasam
Copy link
Collaborator

@Avasam Avasam commented Oct 6, 2024 •
edited
Loading

Split off from #2384 (which only aims at updating online docs with 307).

This PR:

  • Adds type annotations to py2d.py for development and IntelliSense convenience
  • Does the DocInfo initialization work in the DocInfo.__init__ method
  • Creates a subclass of DocInfo to do the same for argument infos generated by the BuildArgInfos method
    • Simplifies usages of should_build_function
  • Makes the Print alias a lot more useful by globally setting file=fp

@Avasam Avasam mentioned this pull request Oct 6, 2024
Merged
Avasam
Avasam commented Oct 6, 2024
View reviewed changes
AutoDuck/py2d.py Show resolved Hide resolved
@Avasam Avasam requested a review from mhammond October 18, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhammond mhammond Awaiting requested review from mhammond

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Avasam