Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Pythonwin displaying syntax errors in Python 3.13 (#2393) #2394

Merged
merged 1 commit into from
Oct 12, 2024
Merged

Fix Pythonwin displaying syntax errors in Python 3.13 (#2393) #2394

merged 1 commit into from
Oct 12, 2024

Conversation

mhammond
Copy link
Owner

No description provided.

@mhammond mhammond requested a review from Avasam October 12, 2024 19:38
Avasam
Avasam approved these changes Oct 12, 2024
View reviewed changes
Copy link
Collaborator

@Avasam Avasam left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this wasn't added to typeshed (I think our tests there didn't catch it because of the **kwargs at runtime). Hence static checker tests can't even catch the incomplete override! I'll open a PR there.
LGTM !

@mhammond mhammond merged commit 4f212e1 into main Oct 12, 2024
63 of 64 checks passed
@mhammond mhammond deleted the push-qytxsxzqylwx branch October 12, 2024 19:55
@mhammond mhammond mentioned this pull request Oct 12, 2024
Closed
@Avasam Avasam mentioned this pull request Oct 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Avasam Avasam Avasam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhammond @Avasam