Fixed Pythonwin's editor failing due to invalid regex import #2419
+9
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
commented
Oct 23, 2024
Avasam
commented
Oct 23, 2024
| @@ -145,8 +145,7 @@ def __radd__(self, other): | |||
|
|
|||
|
|
|||
| # Group(1) is the filename, group(2) is the lineno. | |||
| # regexGrepResult=regex.compile(r"^\([a-zA-Z]:.*\)(\([0-9]+\))") | |||
| # regexGrep=re.compile(r"^([a-zA-Z]:[^(]*)\((\d+)\)") | |||
| # regexGrep = re.compile(r"^([a-zA-Z]:[^(]*)\((\d+)\)") | |||
There was a problem hiding this comment.
Not sure what's the point of this line. Debugging?
Suggested change
| # regexGrep = re.compile(r"^([a-zA-Z]:[^(]*)\((\d+)\)") |
mhammond
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found it odd that pywin32 depends on a third-party regex package. Looking up
regex.symcompand the history of stdlibregexpackage being renamedre, it seems this has been invalid since Python 2 ! Is this entire thing all just dead code ?There's not even any issue mentioning
AttributeError: module 'regex' has no attribute 'symcomp'orNo module named 'regex'. The only somewhat related mention is in #1467 where the user string-searched, not import.