Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added foundation html/css to pagination template #220

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zion
Copy link

@zion zion commented Apr 13, 2017

The idea would be to default to bootstrap styling unless specifying the style argument when calling the component in the template:

{{page-numbers content=users style="foundation"}}

This is my first experience working with an Ember addon locally, so definitely open to ideas to enhance this idea.

@broerse
Copy link
Collaborator

broerse commented Apr 13, 2017

Interested in adding foundation support. But this should be some global setting or perhaps an ember-cli-pagination-foundation with just the template? I will have to think about it.

@zion
Copy link
Author

zion commented Apr 14, 2017 via email

@broerse
Copy link
Collaborator

broerse commented Apr 14, 2017

Perhaps we can do something like this: adopted-ember-addons/ember-infinity@3aa3a4d

@zion
Copy link
Author

zion commented Apr 14, 2017

Yea, that could work. We could also include generator blueprints for each style?

ember g foundation-pagination-template
ember g bootstrap-pagination-template

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants