fix endnodes for condition channels that launch ever if the condition… #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asixela
approved these changes
Jul 4, 2023
Zluurk
approved these changes
Jul 4, 2023
quentinql
force-pushed
the
dvl/quentin/fix_endnodes_condition_channels
branch
from
6dbc46d
to
dbf3d72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… is false
Endnodes are lauch in handle of BaseChannel, and conditionChannels test condition in subhandle so it cause the launch of endnodes even if the condition is not respected.
Move the condition in handle and add tests