STYLE: Make each translatable string a complete sentence in Base/QTCore

Updates on Slicer@6e940aa See also Slicer/SlicerLanguagePacks#12
mhdiop · Jan 8, 2023 · 88d73ca · 88d73ca
1 parent 6e940aa
commit 88d73ca
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 11 deletions.
diff --git a/Base/QTCore/qSlicerAbstractCoreModule.cxx b/Base/QTCore/qSlicerAbstractCoreModule.cxx
@@ -342,8 +342,7 @@ QString qSlicerAbstractCoreModule::defaultDocumentationLink()const
     return "";
     }
   QString url = app->moduleDocumentationUrl(this->name());
-  QString linkText = QString("<p>%1 <a href=\"%2\">%3</a>.</p>")
-                      .arg(tr("For more information see the"))
-                      .arg(url)
-                      .arg(tr("online documentation"));
+  QString linkText = QString("<p>%1</a>.</p>")
+    .arg(tr("For more information see the %1 online documentation").arg("<a href=\"%1\">"))
+    .arg(url);
 }
diff --git a/Base/QTCore/qSlicerCoreApplication.cxx b/Base/QTCore/qSlicerCoreApplication.cxx
@@ -1764,11 +1764,11 @@ QString qSlicerCoreApplication::acknowledgment()const
     tr("Slicer is NOT an FDA approved medical device.") + "<br /><br />" +
     tr("Supported by: NA-MIC, NAC, BIRN, NCIGT and the Slicer Community.") + "<br /><br />" +
     tr("Special thanks to the NIH and our other supporters.") + "<br /><br />" +
-    tr("This work is part of the National Alliance for Medical Image Computing ") +
-    tr("(NA-MIC), funded by the National Institutes of Health through the NIH ") +
-    tr("Roadmap for Medical Research, Grant U54 EB005149. Information on the ") +
-    tr("National Centers for Biomedical Computing can be obtained from ") +
-    "<a href=\"https://commonfund.nih.gov/bioinformatics\">https://commonfund.nih.gov/bioinformatics</a>.<br /><br />");
+    tr("This work is part of the National Alliance for Medical Image Computing "
+    "(NA-MIC), funded by the National Institutes of Health through the NIH "
+    "Roadmap for Medical Research, Grant U54 EB005149. Information on the "
+    "National Centers for Biomedical Computing can be obtained from "
+    "<a href=\"https://commonfund.nih.gov/bioinformatics\">https://commonfund.nih.gov/bioinformatics</a>.<br /><br />"));
   return acknowledgmentText;
 }
 

diff --git a/Base/QTCore/qSlicerCoreIOManager.cxx b/Base/QTCore/qSlicerCoreIOManager.cxx
@@ -578,7 +578,7 @@ bool qSlicerCoreIOManager::loadNodes(const qSlicerIO::IOFileType& fileType,
   bool success = false;
   int numberOfUserMessagesBefore = userMessages ? userMessages->GetNumberOfMessages() : 0;
   //: %1 is the filename
-  QString userMessagePrefix = tr("Loading %1 - ").arg(parameters["fileName"].toString());
+  QString userMessagePrefix = tr("Loading %1").arg(parameters["fileName"].toString()) + " - ";
 
   QStringList nodes;
   foreach (qSlicerFileReader* reader, readers)

diff --git a/Base/QTCore/qSlicerExtensionsManagerModel.cxx b/Base/QTCore/qSlicerExtensionsManagerModel.cxx
@@ -1948,7 +1948,8 @@ bool qSlicerExtensionsManagerModel::installExtension(
         .arg(unresolvedDependencies.join(", "));
       if (d->Interactive)
         {
-        QString msg = QString("<p>%1 %2</p><ul>").arg(extensionName).arg(tr("depends on the following extensions, which could not be found:"));
+        //: %1 is the extension name
+        QString msg = QString("<p>%1</p><ul>").arg(tr("%1 depends on the following extensions, which could not be found:")).arg(extensionName);
         foreach(const QString & dependencyName, unresolvedDependencies)
           {
           msg += QString("<li>%1</li>").arg(dependencyName);