Rework CLI interface #144
Open
Rework CLI interface #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grische
force-pushed
the
rework-cli-interface
branch
4 times, most recently
from
ed1d6db to
8d6db63
Compare
grische
force-pushed
the
rework-cli-interface
branch
from
8d6db63 to
139321e
Compare
grische
force-pushed
the
rework-cli-interface
branch
from
139321e to
3647948
Compare
|
If you prefer a single file solution (because someone has embedded this into their project using a raw GitHub link to the file), we can of course also create a wrapper function that checks if the second argument is type object and then goes the v2 route, else goes the v1 route. Let me know what you think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reworks the CLI of the tool to allow specifiying or overriding the function parameters of the tool on the command-line.
To make this feasible, I needed named parameters for the
jsonToGo()function. In order to not break existing integrations, I named the new functionjsonToGov2(). This is currently fully backwards compatible (as the tests show).@mholt What do you think about the change? Do you have a better name in mind? This is particular about the first commit 4fad829
The other commits are just improvements on the CLI, as well as a backwards-compatibility integration of v1: 0f504683d468d866c3939f2ea4358b4c2b35463f