Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a code based feature flag to the demo #53

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Adding a code based feature flag to the demo #53

wants to merge 2 commits into from

Conversation

JeremyCarlsten
Copy link

We needed to feature flag in an angular controller, not an element on the view. I figured out how to do this so I decided to update your readme and demo.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 1b3ad56 on JeremyCarlsten:master into 6a0f8dc on michaeltaranto:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling e514e24 on JeremyCarlsten:master into 6a0f8dc on michaeltaranto:master.

meetbryce
meetbryce approved these changes Apr 20, 2017
View reviewed changes
Copy link

@meetbryce meetbryce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. It's basically just a documentation update and an example being added to the demo.

@JeremyCarlsten
Copy link
Author

Yep nothing really difficult. Just wanted to share how we were doing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meetbryce meetbryce meetbryce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JeremyCarlsten @coveralls @meetbryce