Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset LRU on leave event of appIcon #1283

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gonzaarcr
Copy link

Like Unity, reset the list of windows when leaveing (unfocusing) the app icon; instead of in a random time.

Like Unity, reset the list of windows when leaveing (unfocusing) the app icon; instead of in a random time.
@micheleg
Copy link
Owner

The code and implementation loog good to me.

I'm not sure this is the best behaviour: when I implemented it this way I thought it was usefull for the icon to remember the position for a while. I agree this was randomly choosen, and your implementation is more determininstic.

Can you suggest a situation where this new behaviour is more natural the the original one?

@gonzaarcr
Copy link
Author

Well, it probably only affects me because I use this feature a lot, I guess nobody uses it. I think the most annoying scenario is when you are slowly changing windows to find one (specially with applications with tabs, which you don’t remember in what windows is what are you looking for) and then you scroll and it take you a while until you realize the scroll was rebooted, and you think you loop throgh all the windows but you didn’t.

@3v1n0
Copy link
Collaborator

3v1n0 commented Jun 16, 2021

I guess this is the kind of case where having a preference to define this would be the best approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants