Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add drag-and-drop assist. #1416

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Valent-in
Copy link

@Valent-in Valent-in commented Apr 17, 2021

Switch windows by dragging and holding item over application icon.
Cycle windows if more than one. Launch app if pinned but not running.
Fixes issue #278

@Valent-in
Copy link
Author

Valent-in commented Apr 17, 2021

UPD: Created workaround for Wayland.

I don't like this:
let scale = St.ThemeContext.get_for_stage(Meta.get_backend().get_stage()).scale_factor;
But screen scaling factor does not applies to mouse coordinates. Probably a bug in toolkit.

@Valent-in Valent-in force-pushed the drag_n_drop_assist branch 2 times, most recently from 1e4ba0b to 86132cc Compare April 18, 2021 12:31
dash.js Outdated Show resolved Hide resolved
@SIMULATAN
Copy link

Exactly what I need, just came here to check if there was any issue regarding this behavior.
Is there any possibility of a merge?

@Valent-in
Copy link
Author

Valent-in commented Jan 3, 2022

Rebase to upstream. Merge conflicts resolved.
Also removed mouse coordinates scaling as it has been fixed in shell toolkit (tested only on version 41).
EDIT: changed commit description.

Switch windows by dragging and holding item over application icon.
Cycle windows if more than one. Launch app if pinned but not running.
Fixes issue micheleg#278
@CosmicFusion
Copy link

Please add this, it will improve usability of gnome 100%

@CosmicFusion
Copy link

Just tried this patch on ubuntu 22.10 gnome 43 wayland, it's awesome can't live without it

@BarbzYHOOL
Copy link

@3v1n0 this looks awesome!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants