Remove any dependency on dockmanager in desktopIconsIntegration.js

[smedir]

Dockmanager can be null, and this spams the log if desktopIconsIntegration class is initialized and used.

Dec 11: JS ERROR: TypeError: DockManager.getDefault() is null
  get extension@file:///home/*/.local/share/gnome-shell/extensions/[email protected]>
  _sendMarginsToExtension@file:///home/*/.local/share/gnome-shell/extensions/dash-to-dock@m>
   _sendMarginsToAll/<@file:///home/*/.local/share/gnome-shell/extensions/dash-to-dock@micxg>
    _sendMarginsToAll@file:///home/*/.local/share/gnome-shell/extensions/dash-to-dock@micxgx.>
   _changedMargins/this._timedMarginsID<@file:///home/*/.local/share/gnome-shell/extensions/>
   @resource:///org/gnome/shell/ui/init.js:21:20

desktopIconsIntegration class is initialized and called from the extension and really should not have any other dependencies other than the shell, it is meant to be used and can be used as is by any extension if called as is independently without modifications.

[3v1n0]

any reason why you closed this?

[smedir]

It happened accidentally, I am not sure what happened. And then I could not figure out how to reopen it, it did not give a choice to reopen it. I am not too familiar with GitHub, on GitLab it is quite easy to re-open the MR. But I did reply to your query, yes the dependencies can be used in your way. I did re-submit the MR as a new one with an added commit that does just that. Although I do feel that the file should be quite independent of the underlying extension, and perhaps the dependencies and imports should not depend on the file structure/paths of the underlying extension. Sundeep

…

On Thu, Feb 15 2024 at 07:01:57 PM -08:00:00, Marco Trevisan ***@***.***> wrote: any reason why you closed this? — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you modified the open/close state.Message ID: ***@***.***>