Fix progress bar colors #2153
Merged
Fix progress bar colors #2153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, I did some extra changes and now it allows to set all the colors using CSS. It is possible to choose between plain colors or gradients, and more. |
|
@jbicha Can you review this when you have some spare time, please? |
|
@3v1n0 Or you, Marco, can you review this when you have some spare time, please? |
3v1n0
reviewed
Mar 12, 2024
3v1n0
reviewed
Mar 12, 2024
As commented in ubuntu/yaru#4016, the progress bar, with its 3D gradient track, doesn't fit very well in the current Gnome/Yaru theme. This patch changes this, moving the track to a planar look, and also allows to set the colors in the CSS.
3v1n0
force-pushed
the
fix-progress-bar-colors
branch
from
6722911
to
558378f
Compare
3v1n0
force-pushed
the
fix-progress-bar-colors
branch
from
558378f
to
781e5c0
Compare
|
Thanks, let's get this in! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As commented in ubuntu/yaru#4016, the progress bar, with its 3D gradient track, doesn't fit very well in the current Gnome/Yaru theme.
This patch changes this, allowing to set all the colors in the bars using CSS: the background color and outline width and color both for the track and the progress bar itself, and also use either plain colors or gradients in each of the four elements, allowing to also specify the start and stop points.