utils: Override async functions with async functions #2163
Conversation
Otherwise gnome-shell (LayoutManager._loadBackground) can't find the override when it was expecting an async function. Closes: micheleg#2110
vanvugt
force-pushed
the
silence-prepareStartupAnimation2
branch
from
56ba256
to
6244ce4
Compare
| object[name] = function (...args) { | ||
| return injectedFunction.call(this, original, ...args); | ||
| }; | ||
| if (original.constructor.name === 'AsyncFunction') { |
There was a problem hiding this comment.
Oh, funny thing... I had this changed months ago and I forgot to commit...
However, define something like const AsyncFunctionType = (async () => {}).constructor; and then check for original instanceof AsyncFunctionType.
Also I feel we should check if the two things match, so if both the original ones are async or not and depending on that behave differently.
There was a problem hiding this comment.
I saw that suggestion when googling but it felt like a hack so I intentionally didn't do it that way. It's uglier, more code, and not obviously correct to me.
Good point about checking two things match though...
Since it turns out the bug #2110 actually isn't important, and it's fixed by #2166, and you have another fix in mind, I suggest just merging your own fix or wait for #2166.
| object[name] = async function (...args) { | ||
| return injectedFunction.call(this, original, ...args); | ||
| }; |
There was a problem hiding this comment.
So, if you're declaring this async and injectedFunction that would be meant to await, so I think you can just drop the async and return the promise as it is no?
Otherwise gnome-shell (
LayoutManager._loadBackground) can't find the override when it was expecting an async function.Closes: #2110