Draft: Restore the missing login animation #2164
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanvugt
force-pushed
the
restore-slide-animation
branch
from
00f948c
to
cc837ff
Compare
Because gnome-shell stopped exporting the value in 45.0 it was being treated as undefined, and therefore we had no startup animation.
Upstream gnome-shell has no parameter for this function, it was only introduced in 8e4f4a8 to fix micheleg#1770 / LP#1965208. But those bugs have resurfaced so we don't need it. And in fact removing the parameter will help us to fix the same bugs, again.
We already called it 8 lines earlier.
So that dock.dash.opacity=0 and we don't see a dock before the startup animation runs.
vanvugt
force-pushed
the
restore-slide-animation
branch
from
cc837ff
to
fdba927
Compare
vanvugt
changed the title
vanvugt
changed the title
|
I think I can do better and rewrite for the new startup animations in GNOME 45/46, rather than continuously adding on... |
|
Moved to #2166 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore the missing login animation, primarily for Ubuntu Dock which has disable-overview-on-startup.
https://bugs.launchpad.net/bugs/2058468