locations: Do not cancel operations after a volume has been umounted / removed #2200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/ removed In case we're unmounting a volume we were optionally removing its icon but this was also leading cancelling the operation that in the Gio queue caused the action not to be fully performed. So once, we've removed a volume or umounted a mount, we don't really care about cancelling the ongoing operations since they should be done already. LP: #1993054
We were still getting a null icon but Gio was warning about so we can just check if it has such attribute first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case we're unmounting a volume we were optionally removing its icon
but this was also leading cancelling the operation that in the Gio queue
caused the action not to be fully performed.
So once, we've removed a volume or umounted a mount, we don't really
care about cancelling the ongoing operations since they should be done
already.
LP: #1993054