locations: Ask again for password on encryption failures #2217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sadly requires parsing the error strings since there are not good APIs yet, but that's how upstream handles this too, so let's accept it for now. See: https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3300
|
Seems to run without error (providing you use GNOME 46 and not 47 (#2223)). So long as it's given time to mature on master and isn't released soon, I'm happy to merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sadly requires parsing the error strings since there are not good APIs yet, but that's how upstream handles this too, so let's accept it for now.
See: https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3300