Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style focused overview-icon backgrounds only for built-in theme #944

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jnsh
Copy link
Contributor

@jnsh jnsh commented May 7, 2019

Focused application's icon is highlighted with light background in stylesheet.css when using custom window counter indicators, or dash-to-dock's built-in theme.

Since that highlight style isn't necessarily visible (if the dock has light background), or simply doesn't look good with some gnome-shell themes, it seems better to style the background only when using the built-in theme, and use default focused styling from the shell theme otherwise.

In addition to the above, the setting label "Customize window counter indicators" implies that it would only have effect on the running dots, and leave any other styling as it is.

This PR removes the focused icon highlight when using custom running dots, and it is only applied for the built-in theme.

Focused application's icon was highlighted with light background
in stylesheet.css when using custom window counter indicators, or
dash-to-dock's built-in theme.

Since that highlight style isn't necessarily visible, or simply
doesn't look good with some gnome-shell themes, it seems better to
style the background only when using the built-in theme, and use
default focused styling from the shell theme otherwise. For that
reason, stop styling the focused icon when using custom indicators.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant