Switch column introspection to use sp_columns instead of cursor.columns #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wgordon17
force-pushed
the
modify-column-introspection
branch
from
9c99990
to
7c74f79
Compare
wgordon17
force-pushed
the
modify-column-introspection
branch
2 times, most recently
from
b0f1b76
to
8b751a9
Compare
wgordon17
force-pushed
the
modify-column-introspection
branch
from
8b751a9
to
bc1c587
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found
cursor.columnsto be less than reliable in returning any results. Thesp_columnsreturns the exact same data, and in local testing, was reliable 100% of the time for ~520 tables.