Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data logging fixes #8

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Data logging fixes #8

wants to merge 5 commits into from

Conversation

microbit-carlos
Copy link
Collaborator

@microbit-carlos microbit-carlos commented Aug 24, 2021

The original commits in this PR have been pushed here from @gerargz branch (thanks!): a7b614e

@microbit-carlos
Copy link
Collaborator Author

As indicated in the PR timeline, I've rebased the latest upstream master and forced pushed (head before was a7b614e, and now is 096519d)
This was so that any testing builds from this branch can have all the latest changes from main, as this would include the last commits added to microbit_features upstream PR before it was merged, as they were added before this branch was originally created.

@microbit-carlos
Copy link
Collaborator Author

Build using Keil with armcc, git hash 096519dbccc60d6ca86c60dd8dede8cda195b18d:

-Ignore NOP cmd when clearing TX buffer and adding busy error code
@microbit-carlos
Copy link
Collaborator Author

b7e6a0e build from Gerardo: kl27z_microbit_if_b7e6a0e.zip

-Don't clear I2C buffer at the start of flash command handling.
-Keep interrupt signal asserted when busy error was read.
-Don't clear I2C TX Buffer after reads. Allowing multiple reads of last result.
-Enable UART HW overrun interrupt.
-Reduce time spent in I2C IRQ handler to avoid UART overrun and data loss.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants