Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

media-fonts/Shanggu: new package, add 1.021 #5649

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Linerre
Copy link
Contributor

@Linerre Linerre commented Nov 17, 2024

fix #5648

@curlingchimpanzeeowl if you'd like to maintain this font, feel free to modify the overlay.toml file:

- github_account = "Linerre"` 
+ github_account = "curlingchimpanzeeowl"

so that you will be notified when there is a newer version of this font released by the upstream.

You may also want to change the maintainer in the metadata.xml file to be consistent.

I have tested other font families by issuing the following

USE="sans mono round" emerge -av1 media-fonts/Shanggu"

The full installation takes up 4.5GB however, just for your reference:

[ebuild  N     ] media-fonts/Shanggu-1.021::gentoo-zh  USE="X mono round sans serif" 0 KiB

Total: 1 package (1 new), Size of downloads: 0 KiB

Would you like to merge these packages? [Yes/No] 
>>> Verifying ebuild manifests
>>> Emerging (1 of 1) media-fonts/Shanggu-1.021::gentoo-zh
>>> Installing (1 of 1) media-fonts/Shanggu-1.021::gentoo-zh
>>> Completed (1 of 1) media-fonts/Shanggu-1.021::gentoo-zh
>>> Jobs: 1 of 1 complete                                               Load avg: 0.67, 0.24, 0.08

 * Messages for package media-fonts/Shanggu-1.021:
 * Log file: /var/log/portage/build/media-fonts/Shanggu-1.021:20241117-041516.log

 * Package:    media-fonts/Shanggu-1.021:0
 * Repository: gentoo-zh
 * USE:        X abi_x86_64 amd64 elibc_glibc kernel_linux mono round sans serif
 * FEATURES:   network-sandbox preserve-libs sandbox userpriv usersandbox
 * Creating fonts.scale & fonts.dir in ShangguSerif
 * Creating fonts.scale & fonts.dir in ShangguSerifFANTI
 * Creating fonts.scale & fonts.dir in ShangguSerifJP
 * Creating fonts.scale & fonts.dir in ShangguSerifSC
 * Creating fonts.scale & fonts.dir in ShangguSerifTC
 * Creating fonts.scale & fonts.dir in ShangguSans
 * Creating fonts.scale & fonts.dir in ShangguSansFANTI
 * Creating fonts.scale & fonts.dir in ShangguSansJP
 * Creating fonts.scale & fonts.dir in ShangguSansSC
 * Creating fonts.scale & fonts.dir in ShangguSansTC
 * Creating fonts.scale & fonts.dir in ShangguMono
 * Creating fonts.scale & fonts.dir in ShangguMonoJP
 * Creating fonts.scale & fonts.dir in ShangguMonoSC
 * Creating fonts.scale & fonts.dir in ShangguMonoTC
 * Creating fonts.scale & fonts.dir in ShangguRound
 * Creating fonts.scale & fonts.dir in ShangguRoundFANTI
 * Creating fonts.scale & fonts.dir in ShangguRoundJP
 * Creating fonts.scale & fonts.dir in ShangguRoundSC
 * Creating fonts.scale & fonts.dir in ShangguRoundTC
 * Final size of build directory: 4815880 KiB (4.5 GiB)
 * Final size of installed tree:  4816556 KiB (4.5 GiB)
 * Updating global fontcache ...

 * GNU info directory index is up-to-date.

Copy link

✔️ pkgcheck checks passed


src_install() {
if use serif; then
FONT_S=(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是否可以用数组append的方式更新FONT_S,这样整个src_install都可以省略。
https://stackoverflow.com/questions/1951506/add-a-new-element-to-an-array-without-specifying-the-index-in-bash

Copy link
Contributor Author

@Linerre Linerre Nov 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我看看能不能把显式的 src_install 去掉

Copy link
Contributor Author

@Linerre Linerre Nov 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
FONT_S=(
FONT_S=()
use serif && FONT_S+=(
"${WORKDIR}/${PN}Serif"
"${WORKDIR}/${PN}SerifFANTI"
"${WORKDIR}/${PN}SerifJP"
"${WORKDIR}/${PN}SerifSC"
"${WORKDIR}/${PN}SerifTC"
)
use sans && FONT_S+=(
"${WORKDIR}/${PN}Sans"
"${WORKDIR}/${PN}SansFANTI"
"${WORKDIR}/${PN}SansJP"
"${WORKDIR}/${PN}SansSC"
"${WORKDIR}/${PN}SansTC"
)
use mono && FONT_S+=(
"${WORKDIR}/${PN}Mono"
"${WORKDIR}/${PN}MonoJP"
"${WORKDIR}/${PN}MonoSC"
"${WORKDIR}/${PN}MonoTC"
)
use round && FONT_S+=(
"${WORKDIR}/${PN}Round"
"${WORKDIR}/${PN}RoundFANTI"
"${WORKDIR}/${PN}RoundJP"
"${WORKDIR}/${PN}RoundSC"
"${WORKDIR}/${PN}RoundTC"
)

这样呢? 但好像没见过 use flagxxx 在 phase function 外面用的……

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Additional Package Request: media-fonts/shanggu
2 participants