Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getMapAsync() for LiteGoogleMap #2531

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

jonathanklee
Copy link
Contributor

Spotify was crashing because of some lateinit property in Spotify snapshot ready callback was not initialized.

Looking at the condition we can observe that GmsCore was calling the snapshot ready callback when the snapshot was null, which does not make sense.

Inverting the logic and calling the callback when the snapshot was not null anymore fixed the issue and Spotify was able to display the snapshot.

Spotify was crashing because of some lateinit property in Spotify snapshot ready
callback was not initialized.

Looking at the condition we can observe that GmsCore was calling the snapshot ready
callback when the snapshot was null, which does not make sense.

Inverting the logic and calling the callback when the snapshot was not null anymore
fixed the issue and Spotify was able to display the snapshot.
Copy link
Contributor

@fynngodau fynngodau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The log messages make it obvious that I mixed this up. Thanks :)

@mar-v-in mar-v-in added this to the 0.3.4 milestone Sep 24, 2024
@mar-v-in mar-v-in merged commit d9df3fa into microg:master Sep 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants