Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Help: Improve the link target #2536

Merged
merged 6 commits into from
Sep 28, 2024
Merged

Conversation

DaVinci9196
Copy link
Contributor

@DaVinci9196 DaVinci9196 commented Sep 11, 2024

The test found that there are two places where you cannot jump to the help page.

  1. Gmail meeting menu pop-up window click to learn more Unable to jump.
  2. Clicking Learn how to verify your phone number on the Meet add phone number page does not redirect.

@mar-v-in
Copy link
Member

I don't think it's relevant that we sign in the account to view help pages, so instead of using an authorized web view, you could safely redirect to the browser (as was done before) after retrieving the URL.

@DaVinci9196
Copy link
Contributor Author

I don't think it's relevant that we sign in the account to view help pages, so instead of using an authorized web view, you could safely redirect to the browser (as was done before) after retrieving the URL.

Accepted, thanks

@ale5000-git
Copy link
Member

ale5000-git commented Sep 12, 2024

@DaVinci9196
Copy link
Contributor Author

DaVinci9196 commented Sep 12, 2024

@ale5000-git
I need to jump to an external browser, how can I do this?

@mar-v-in mar-v-in added this to the 0.3.4 milestone Sep 24, 2024
@mar-v-in mar-v-in changed the title Improve the Help link Google Help: Improve the link target Sep 28, 2024
@mar-v-in mar-v-in merged commit 09cf3c8 into microg:master Sep 28, 2024
1 check passed
@DaVinci9196 DaVinci9196 deleted the help_redirect branch October 8, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants