Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PI: Fix Failed to generate key pair and related crashes #2740

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

DaVinci9196
Copy link
Contributor

java.security.ProviderException: Failed to generate key pair.
at android.security.keystore2.AndroidKeyStoreKeyPairGeneratorSpi.generateKeyPairHelper(AndroidKeyStoreKeyPairGeneratorSpi.java:620)
at android.security.keystore2.AndroidKeyStoreKeyPairGeneratorSpi.generateKeyPair(AndroidKeyStoreKeyPairGeneratorSpi.java:545)
at java.security.KeyPairGenerator$Delegate.generateKeyPair(KeyPairGenerator.java:727)

@ale5000-git
Copy link
Member

ale5000-git commented Jan 10, 2025

@DaVinci9196
Look at this: https://github.com/microg/GmsCore/pull/2199/files
Apparently some devices fails when attestation challenge is set, I wonder if it make sense to do the same as in PR #2199 also in Play Integrity (retry without attestation challenge if it fails with ProviderException).

@DaVinci9196
Copy link
Contributor Author

@DaVinci9196 Look at this: https://github.com/microg/GmsCore/pull/2199/files Apparently some devices fails when attestation challenge is set, I wonder if it make sense to do the same as in PR #2199 also in Play Integrity (retry without attestation challenge if it fails with ProviderException).

Very good idea, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants