refactor: only handle browser errors

microlinkhq · Sep 12, 2024 · 2c4a251 · 2c4a251
1 parent a0f4d79
commit 2c4a251
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/packages/errors/index.js b/packages/errors/index.js
@@ -80,4 +80,7 @@ browserlessError.ensureError = rawError => {
   return require('ensure-error')(error)
 }
 
+const isBrowserlessError = error => error.name === ERROR_NAME
+
 module.exports = browserlessError
+module.exports.isBrowserlessError = isBrowserlessError
diff --git a/packages/function/src/index.js b/packages/function/src/index.js
@@ -1,6 +1,6 @@
 'use strict'
 
-const { ensureError, browserTimeout } = require('@browserless/errors')
+const { isBrowserlessError, ensureError, browserTimeout } = require('@browserless/errors')
 const debug = require('debug-logfmt')('browserless:function')
 const requireOneOf = require('require-one-of')
 const pTimeout = require('p-timeout')
@@ -45,7 +45,9 @@ module.exports =
 
         const result = await withVM()
         if (result.isFulfilled) return result
-        throw ensureError(result.value)
+        const error = ensureError(result.value)
+        if (isBrowserlessError(error)) throw ensureError(error)
+        return result
       }
 
       const task = () =>