Add support for root name as jsx element #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kikobeats
reviewed
Oct 24, 2023
src/js/components/JsonViewer.js
Outdated
| let ObjectComponent = JsonObject; | ||
| if (typeof props.name === 'object' && !Array.isArray(props.name)) { | ||
| namespace = ['ReactElement']; |
There was a problem hiding this comment.
what if namespace = props.displayName ? 🤔
There was a problem hiding this comment.
Great idea! Added it.
Also handled If component is unnamed It will use Anonymous exactly the same as most of the react debug tools
|
@snoh666 thanks for this; I totally forgot 🙏 |
|
@snoh666 is "npm run build" working fine to you? |
Actually I can see some deps error related to create-react-app and babel |
|
Yes :( I want to release your PR in the next version, but the building fails. I'm trying to determine what's happening. |
|
I'm pretty sure this should be a working fix #28 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of requirement of my current project we needed to use customary designs root name of each tree so easiest solution would be to pass React Element
After trying some sketchy stuff I realized when I type cast
JSX.Element as stringnothing breaks within the library so started on checking out library code.After realization because of the support of
falsevalues inObjectAttributesobjecttype also works perfectly fine with exception that ObjectAttributes contains[Object object]as keyso it needed only adding handling to replace this
{} to stringto just be"ReactElement" stringWhich I thought is the most appropriate name