Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust storage tests #25

Merged
merged 2 commits into from
Sep 17, 2023
Merged

Conversation

jessepeterson
Copy link
Member

Adjust storage tests to:

  • Split the test functions to allow using the individual tests, if desired.
  • Use random-ish DEP names (largely to be able to run tests in an existing MySQL database).
  • Adjust MySQL GitHub actions integration tests to:
    • Use services definition in the job (vs. separate docker-compose)
    • Specify DSN in envvar
    • Move MySQL setup & tear down into GH actions (vs. in the test code)
      • This decouples the test infra from the tests (which were hardcoded)

@jessepeterson jessepeterson merged commit 6ea0a2c into micromdm:main Sep 17, 2023
4 checks passed
@jessepeterson jessepeterson deleted the storage-test-adj branch September 17, 2023 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant