Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for alias selection in the keystore #11503

Open
wants to merge 1 commit into
base: 4.8.x
Choose a base branch
from

Conversation

viniciusxyz
Copy link
Contributor

@viniciusxyz viniciusxyz commented Jan 13, 2025

The approach used is very simple, the content of the alias is extracted and a new object representing a keystore is created only with that alias, this way it is possible to load only the desired alias and no more errors occur when we have multiple aliases in the keystore each with a password

Related issue #11430

@viniciusxyz viniciusxyz changed the title Added support for alias selection in the keystore - Related issue #11430 Added support for alias selection in the keystore Jan 13, 2025
@viniciusxyz viniciusxyz force-pushed the feature/support-for-alias-selection-in-keystore branch from 01cc68d to 2a8e576 Compare January 13, 2025 17:34
@viniciusxyz viniciusxyz force-pushed the feature/support-for-alias-selection-in-keystore branch from 2a8e576 to 5a3bbb4 Compare January 14, 2025 12:00
@sdelamo sdelamo requested a review from yawkat January 15, 2025 08:29
Copy link
Contributor

@sdelamo sdelamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test?

@viniciusxyz
Copy link
Contributor Author

Could you add a test?

for sure, I will do it today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants