Rework build logic #104
Merged
Rework build logic #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yawkat
reviewed
Jan 7, 2025
fuzzing-model/src/main/java/io/micronaut/fuzzing/model/DefinedFuzzTarget.java
Outdated
Show resolved
Hide resolved
This commit reworks how the model class is "shared" between the annotation processor and the jazzer plugin. Instead of using a symlink, the code is now generated by a common build plugin. In practice, the 2 modules use the same record, but in a different package. It's also cleaner in the sense that there's no dependency between the plugin and the annotation processor, which would have led to too many classes on classpath. Fixes #101
yawkat
reviewed
Jan 7, 2025
| useStandardizedProjectNames = true | ||
|
|
||
| importMicronautCatalog() | ||
|
|
||
| requiresDevelopmentVersion("micronaut-core", "4.8.x") |
There was a problem hiding this comment.
One thought: Is this requiresDevelopmentVersion thing going to mess with the explicit micronaut version in the jazzer-plugin, or with the central publishing process?
requiresDevelopmentVersion is only really needed for the fuzzing-tests module, but there it really is needed, so it needs to stay in the repo
|
Also FYI, I'm going to move DefinedFuzzTarget from the processor to fuzzing-api, because I want to introduce an API to run a fuzz test from main with a simple method call. It should work with the approach in this PR, but just so you know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit reworks how the model class is "shared" between the annotation processor and the jazzer plugin. Instead of using a symlink, the code is now generated by a common build plugin. In practice, the 2 modules use the same record, but in a different package. It's also cleaner in the sense that there's no dependency between the plugin and the annotation processor, which would have led to too many classes on classpath.
Fixes #101