Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update managed.protobuf to v4 (major) #867

Closed
wants to merge 3 commits into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 23, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
com.google.protobuf:protobuf-bom (source) 3.25.3 -> 4.26.0 age adoption passing confidence
com.google.protobuf:protoc (source) 3.25.3 -> 4.26.0 age adoption passing confidence
com.google.protobuf:protobuf-java-util (source) 3.25.3 -> 4.26.0 age adoption passing confidence
com.google.protobuf:protobuf-kotlin-lite (source) 3.25.3 -> 4.26.0 age adoption passing confidence
com.google.protobuf:protobuf-kotlin (source) 3.25.3 -> 4.26.0 age adoption passing confidence
com.google.protobuf:protobuf-javalite (source) 3.25.3 -> 4.26.0 age adoption passing confidence
com.google.protobuf:protobuf-java (source) 3.25.3 -> 4.26.0 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - "after 10pm" in timezone Europe/Prague, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the type: dependency-upgrade Upgrade a dependency label Mar 23, 2024
Copy link
Contributor Author

renovate bot commented Mar 27, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@wetted
Copy link
Contributor

wetted commented Mar 27, 2024

This is blocked by the issues described in grpc/grpc-java#11015.

com.google.protobuf 4.26.0 has breaking changes that are not compatible with grpc-protobuf. I have fixed some compile issues but there is still an incompatibility due to this breaking change: "[Java] The base class for generated messages will be GeneratedMessage, not GeneratedMessageV3", where grpc-protobuf still generates message classes inheriting from GeneratedMessageV3 (i.e. the older version of google protobuf).

@graemerocher graemerocher added the status: next major version The issue will be considered for the next major version label Jun 3, 2024
@sdelamo sdelamo closed this Nov 5, 2024
Copy link
Contributor Author

renovate bot commented Nov 5, 2024

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 4.x releases. But if you manually upgrade to 4.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@renovate renovate bot deleted the renovate/major-managed.protobuf branch November 5, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: next major version The issue will be considered for the next major version type: dependency-upgrade Upgrade a dependency
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants