Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to core 4.0.0-RC3 #1077

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Upgrade to core 4.0.0-RC3 #1077

merged 1 commit into from
Jun 21, 2023

Conversation

melix
Copy link
Contributor

@melix melix commented Jun 21, 2023

No description provided.

@melix melix requested a review from sdelamo June 21, 2023 08:52
@melix melix self-assigned this Jun 21, 2023
@melix melix marked this pull request as ready for review June 21, 2023 08:52
@sonarcloud
Copy link

sonarcloud bot commented Jun 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sdelamo
sdelamo approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@sdelamo sdelamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you change to use the Micronaut HTTP Client Java based instead of the net one?

@melix
Copy link
Contributor Author

melix commented Jun 21, 2023

Why did you change to use the Micronaut HTTP Client Java based instead of the net one?

mmm, I simply changed the implementation to use micronaut-http because the generated code uses annotations from this project. I moved the micronaut-http-client to testImplementation only because it wasn't required by the generated server code but only for tests.

@sdelamo sdelamo merged commit 25ffe29 into master Jun 21, 2023
7 checks passed
@sdelamo sdelamo deleted the cc/to-core-rc3 branch June 21, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdelamo sdelamo sdelamo approved these changes

Assignees

@melix melix

Labels
None yet
Projects
No open projects
4.0.0-RC1 Release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@melix @sdelamo