OpenAPI Generator Return type Improvements #1098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add an option to generate HttpResponse only where it is required - Use Flux for list return types when reactive = true
|
there are failing tests |
|
|
|
Flux or publisher response is always streaming the content. In my benchmarking Flux is much slower than Mono<List> If you have a single response use Mono, or @SingleResult Publisher / Flux. For returning a list of values is always better to use collectList and Mono |
|
SonarCloud Quality Gate failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements for the operation return type:
HttpResponsecan be generated only where required (a response header is used or status code other than 200)Fluxis returned for iterable types instead ofMono<List<>>when using reactive return types