Add ability to set project directory. #1115
Conversation
|
@graemerocher Hi! Could you review and merge last 3 PR's (#1115, #1112, #1113) ? After it we can release 4.10.0 - last of 4.x series. Then I move these changes to relese 5.0 and all next changes will be in release 5.0 (except for bug fixes, of course) |
|
@graemerocher Could you also review this PR and #1113 ? |
| /** | ||
| * Loaded project directory from system properties. | ||
| */ | ||
| public static final String MICRONAUT_INTERNAL_OPENAPI_PROJECT_DIR = "micronaut.internal.openapi.project.dir"; |
There was a problem hiding this comment.
Could you override getSupportedOptions() and provide all of these constants as annotation processor options
There was a problem hiding this comment.
As I understand, this block do the same
| return projectPath; | ||
| } | ||
|
|
||
| String projectDir = System.getProperty(MICRONAUT_OPENAPI_PROJECT_DIR); |
There was a problem hiding this comment.
you shouldn't use system properties but the annotation processor options otherwise the compiler can't detect when input values change
There was a problem hiding this comment.
I don't quite understand what's wrong here. As I understand it, it is necessary to describe the properties of the processor, which must be allowed to be loaded as system variables. They are described in the @SupportedOptions annotation. Now everything has been implemented.
There was a problem hiding this comment.
in general parameters to an annotation processor should never be ready from system properties and should always be read from annotation processor arguments, this particular processor abuses that badly in several places which is less than ideal.
There was a problem hiding this comment.
I see, then how is it correct to write the reading of the arguments? Although I'm not sure if there's much to worry about using system variables. I think it's redundant
There was a problem hiding this comment.
@graemerocher Do I need to write something like this?
context.getOptions().get(MICRONAUT_INTERNAL_OPENAPI_PROJECT_DIR)There was a problem hiding this comment.
It's just that I don't understand. I give kapt the annotation processor argument, but I read it with a system property. That is, it turns out that all arguments are already available as system properties. Or does kapt set not an argument, but a system property?
I tested this solution on a test project - it works correctly.
There was a problem hiding this comment.
yes it needs to be context.getOptions().get(MICRONAUT_INTERNAL_OPENAPI_PROJECT_DIR)
|
@graemerocher Can I merge it? |
altro3
force-pushed
the
project_dir
branch
3 times, most recently
from
7c3cc58
to
c10d8f9
Compare
|
@sdelamo done |
|
@graemerocher Can I publish releases |
Fixed #1101