Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuration improvements #1149

Merged
merged 2 commits into from
Aug 5, 2023
Merged

Configuration improvements #1149

merged 2 commits into from
Aug 5, 2023

Conversation

altro3
Copy link
Collaborator

@altro3 altro3 commented Jul 29, 2023

Improvements in classes structure:

  1. Move configuration methods to ConfigUtils class
  2. Move file methods to FileUtils class
  3. Added autosave to context already loaded config value
  4. Replace System.getProperty(...) to context.getOptions().get(...) for supported annotaton processor options

@altro3
Copy link
Collaborator Author

altro3 commented Jul 29, 2023 •
edited
Loading

@graemerocher Hi! Now all as you want: I use context.getOperations.get() instead System.getProperty()

@altro3 altro3 changed the title Configuration inprovements Configuration improvements Jul 29, 2023
@altro3 altro3 requested a review from graemerocher July 30, 2023 17:03
graemerocher
graemerocher approved these changes Aug 1, 2023
View reviewed changes
openapi/src/main/java/io/micronaut/openapi/visitor/ConfigProperty.java Outdated
*
* @since 4.10.0
*/
public interface ConfigProperty {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rename this to something less generic like OpenApiConfigProperty or something

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@graemerocher fixed

@altro3
Fixes replace placeholders
83d9c3f 
Fixed micronaut-projects#1143
@altro3
Improvements in classes structure:
6a78c58 
1. Move configuration methods to ConfigUtils class
2. Move file methods to FileUtils class
3. Added autosave to context already loaded config value
4. Replace System.getProperty(...) to context.getOptions().get(...) for supported annotaton processor options
@altro3
Copy link
Collaborator Author

altro3 commented Aug 3, 2023

@graemerocher sorry, I need to revert context.getOptions().get(...) to System.getProperty(...) because of it micronaut-projects/micronaut-core#9671

@altro3 altro3 merged commit 32299c6 into micronaut-projects:4.10.x Aug 5, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graemerocher graemerocher Awaiting requested review from graemerocher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@altro3 @graemerocher