-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create OpenAPI Kubernetes client integration with OKE #1041
Conversation
❌ Oracle Cloud CI 17 latest failed: https://ge.micronaut.io/s/trxptrkgnqtwc |
...client/src/main/java/io/micronaut/oraclecloud/oke/kubernetes/client/OkeKubeConfigLoader.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/micronaut/oraclecloud/oke/kubernetes/client/OkeKubernetesClientConfig.java
Show resolved
Hide resolved
.../src/main/java/io/micronaut/oraclecloud/oke/kubernetes/client/OkeKubernetesClientConfig.java
Show resolved
Hide resolved
.../main/java/io/micronaut/oraclecloud/oke/kubernetes/client/OkeKubernetesCredentialLoader.java
Show resolved
Hide resolved
.../main/java/io/micronaut/oraclecloud/oke/kubernetes/client/OkeKubernetesCredentialLoader.java
Show resolved
Hide resolved
.../main/java/io/micronaut/oraclecloud/oke/kubernetes/client/OkeKubernetesCredentialLoader.java
Outdated
Show resolved
Hide resolved
❌ Oracle Cloud CI 17 latest failed: https://ge.micronaut.io/s/ajgx6bmyofemw |
Strange, it says region provider is missing. But it should not be required if endpoint was set explicitly. I don't even see RegionProvider injected in the
|
❌ Oracle Cloud CI 17 latest failed: https://ge.micronaut.io/s/yu7mwl3epdbqq |
...ent/src/test/groovy/io/micronaut/oraclecloud/oke/kubernetes/client/MockKubernetesSpec.groovy
Outdated
Show resolved
Hide resolved
352758c
to
dbea8db
Compare
Quality Gate failedFailed conditions See analysis details on SonarQube Cloud Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE |
The sonar reports that volatile isn't enough for thread safe code. |
I copied the volatile part from our openapi kubernetes client credential loader implementation. I think it fine, as implementation only uses volatile when getting the token. When it needs to set the token, it uses a |
Integration the OpenAPI Kubernetes client with OKE that adds:
OkeKubeConfigLoader
that loads kubeconfig from a specified cluster with the OCI Container Engine client.OkeKuberenetesCredentialLoader
that provides token for OKE server requests. The tokens are based on the OCIAuthenticationDetailsProvider