Skip to content

Commit

Permalink
Use reactor bom, removed netty-http dependency (#669)
Browse files Browse the repository at this point in the history
* Use reactor bom, removed netty-http dependency

* Disable compatibility check

* Update binary compatibilitie

* Update build.gradle

* Update build.gradle
  • Loading branch information
radovanradic authored Nov 5, 2024
1 parent 4bfd574 commit ae5f341
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 9 deletions.
7 changes: 0 additions & 7 deletions gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ micronaut-validation = "4.8.0"
micronaut-logging = "1.3.0"

groovy = "4.0.18"
testcontainers = "1.19.4"

# R2DBC Drivers

Expand All @@ -35,9 +34,6 @@ micronaut-gradle-plugin = "4.4.3"
micronaut-test-resources = "2.6.2"
kotlin-gradle-plugin = "1.9.25"

# Reactory Netty Dependencies
managed-reactor-netty = "1.1.22"

[libraries]
# Core
micronaut-core = { module = 'io.micronaut:micronaut-core-bom', version.ref = 'micronaut' }
Expand Down Expand Up @@ -68,9 +64,6 @@ managed-r2dbc-io-asyncer-mysql = { module = "io.asyncer:r2dbc-mysql", version.re
managed-r2dbc-mssql = { module = "io.r2dbc:r2dbc-mssql", version.ref = "managed-r2dbc-mssql" }
managed-r2dbc-postgresql = { module = "org.postgresql:r2dbc-postgresql", version.ref = "managed-r2dbc-postgresql" }

# Reactor Netty Dependencies
managed-reactor-netty-http = { module = "io.projectreactor.netty:reactor-netty-http", version.ref = "managed-reactor-netty" }

testcontainers-junit-jupiter = { module = "org.testcontainers:junit-jupiter" }

junit-platform-engine = { module = "org.junit.platform:junit-platform-suite-engine" }
Expand Down
4 changes: 4 additions & 0 deletions r2dbc-bom/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,9 @@ micronautBom {
// We used to erroneously manage testcontainers (prior to 5.2.0)
acceptedLibraryRegressions.add("boms-testcontainers")
acceptedVersionRegressions.add("testcontainers")
// Removed reactor-netty-http added in 5.6.0 and now using mnReactor BOM
acceptedVersionRegressions.add("reactor-netty")
acceptedLibraryRegressions.add("reactor-netty-http")
}
}

3 changes: 1 addition & 2 deletions r2dbc-core/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,7 @@ dependencies {
api(mnValidation.micronaut.validation)
api(libs.managed.r2dbc.spi)

api(libs.managed.reactor.netty.http)

api(platform(mnReactor.boms.reactor))
implementation(mn.reactor)

testImplementation(mn.micronaut.management)
Expand Down

0 comments on commit ae5f341

Please sign in to comment.