Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix consuming null in DemuxingObjectDecoder #655

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Fix consuming null in DemuxingObjectDecoder #655

merged 2 commits into from
Nov 9, 2023

Conversation

dstepanov
Copy link
Contributor

@graemerocher graemerocher added the type: bug Something isn't working label Nov 9, 2023
@yawkat
Copy link
Member

yawkat commented Nov 9, 2023

i dont understand why this is necessary, let me check

@yawkat
Copy link
Member

yawkat commented Nov 9, 2023

ohh i understand. i will make a tiny change to the naming because i found this code very confusing :)

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@dstepanov dstepanov merged commit 5c5ced0 into master Nov 9, 2023
11 checks passed
@dstepanov dstepanov deleted the mf branch November 9, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yawkat yawkat yawkat approved these changes

@graemerocher graemerocher graemerocher approved these changes

Assignees
No one assigned
Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dstepanov @yawkat @graemerocher