This repository has been archived by the owner on Dec 5, 2023. It is now read-only.
Enrich Zipkin db tracing #56
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Relates to microservices-demo/microservices-demo#755 |
Add info regarding - database type and address - approximation for queries results size
embs
force-pushed
the
enhancement/zipkin-db-tracing
branch
from
eb6b2b9
to
c8496f7
Compare
|
Improved to include spans'
|
added 2 commits
November 29, 2017 23:18
So we can properly trace database calls for fetching user addresses and user cards.
For tracing db.query.result.size span tag.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add info regarding
What db traces looked like before enrichment:
How they look like
now(see #56 (comment)):I was inspired by https://github.com/opentracing/specification/blob/master/semantic_conventions.md for choosing some binary annotations keys.